-
Notifications
You must be signed in to change notification settings - Fork 29
feat: shared workflow for sbom export from socket.dev API #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, they are mostly nits, there's no blocker, they are only recommendations. 🙂
The only blocking thing is that this should be added to our release-please-config.json similar to this diff.
guicaulada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I caught a few other things on a second look that you might want to change.
If you could, please try to call this action a separate repository on a test workflow with the example of your README so we can have a test run.
I wouldn't be able to call from this repo until it's merged or is that possible? |
Adds a shared workflow that can be used to export the SPDX SBOM for a repo enrolled in the socket.dev GitHub app based on the most recent scan.