feat: emit sigil.gen_ai.tool_call_count span attribute#17
Draft
alexander-akhmetov wants to merge 1 commit intomainfrom
Draft
feat: emit sigil.gen_ai.tool_call_count span attribute#17alexander-akhmetov wants to merge 1 commit intomainfrom
alexander-akhmetov wants to merge 1 commit intomainfrom
Conversation
Set tool_call_count as an int64 span attribute on generation spans, letting users filter by tool call count.
Collaborator
Author
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit afac177. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set tool_call_count as an int64 span attribute on
generation spans, letting users filter by tool call count.
Note
Low Risk
Low risk: adds a new optional span attribute derived from existing generation output without changing export formats or control flow beyond extra tag setting and test assertions.
Overview
Adds a new generation-span attribute,
sigil.gen_ai.tool_call_count, emitted when tool-call parts are present in the model output (Dotnet/Go/Java/JS/Python).Updates conformance tests across SDKs to assert the new attribute is set (and makes JS
generation.outputoptional to support counting when present).Reviewed by Cursor Bugbot for commit afac177. Bugbot is set up for automated code reviews on this repo. Configure here.