feat(claude-code): use SDK ContentCaptureMode instead of manual stripping#25
Draft
alexander-akhmetov wants to merge 1 commit intomainfrom
Draft
feat(claude-code): use SDK ContentCaptureMode instead of manual stripping#25alexander-akhmetov wants to merge 1 commit intomainfrom
alexander-akhmetov wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
bugbot review |
…ping Let the SDK handle content stripping via Config.ContentCapture instead of the plugin's own buildOutputRedacted path. The mapper now always builds full content; the SDK strips it in SetResult when the mode is metadata_only. Configured via SIGIL_CONTENT_CAPTURE_MODE env var (full, metadata_only, no_tool_content), defaulting to metadata_only. SIGIL_CONTENT_CAPTURE=true is still supported as a legacy fallback mapping to full mode.
d2eeead to
2e6fbd4
Compare
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d2eeead. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the SDK handle content stripping via Config.ContentCapture instead of the plugin's own
buildOutputRedactedpath. Configured viaSIGIL_CONTENT_CAPTURE_MODEenv var (full,metadata_only,no_tool_content), defaulting tometadata_only.Note
Medium Risk
Changes how conversation/tool content is included and redacted in exported generations and tool spans; mistakes could unintentionally increase captured sensitive data, though defaults and invalid-mode handling fail back to
metadata_only. The change is isolated to the Claude Code plugin’s telemetry pipeline and updates tests/docs accordingly.Overview
Switches the Claude Code
sigil-cchook from a booleanSIGIL_CONTENT_CAPTUREflag and plugin-side redaction/[redacted]output generation to the SDK’sConfig.ContentCaptureusingSIGIL_CONTENT_CAPTURE_MODE(full,metadata_only,no_tool_content).The mapper no longer conditionally strips content; it always builds
Generationinput/output and relies on the SDK to strip content formetadata_only, while the plugin only instantiates the redactor when content modes include text. Tool execution spans are updated to always populate arguments/results, with inclusion governed by the SDK mode, and tests/docs are updated plus legacy env var support is preserved viaresolveContentMode().Reviewed by Cursor Bugbot for commit d2eeead. Bugbot is set up for automated code reviews on this repo. Configure here.