fix(sigil-cc): use cumulative temporality for OTLP metrics#28
Draft
alexander-akhmetov wants to merge 1 commit intomainfrom
Draft
fix(sigil-cc): use cumulative temporality for OTLP metrics#28alexander-akhmetov wants to merge 1 commit intomainfrom
alexander-akhmetov wants to merge 1 commit intomainfrom
Conversation
Delta temporality histograms are rejected by Grafana Cloud's OTLP gateway, so gen_ai.client.* metrics never reached Prometheus.
Collaborator
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 89e4578. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delta temporality histograms are rejected by Grafana Cloud's OTLP gateway, so gen_ai.client.* metrics never reached Prometheus.
Note
Low Risk
Low risk telemetry-only change; it alters metric temporality/output format which could affect downstream dashboards/alerts but not application behavior.
Overview
Stops forcing OTLP HTTP metrics to use delta temporality by removing the custom
WithTemporalitySelectorconfiguration (and themetricdatadependency), so the exporter uses the default cumulative temporality for better compatibility with backends like Grafana Cloud OTLP.Reviewed by Cursor Bugbot for commit 89e4578. Bugbot is set up for automated code reviews on this repo. Configure here.