feat: new check editor #1280
Merged
feat: new check editor #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dump code on to fresh `main` branch - add feature flag `synthetic-monitoring-check-editor` (`FeatureName.CheckEditor`) - wire up routes (edit/new) - create submit handler hook - create after save nav hook for checks - add new datasource method
- remove `console.log` (except one)
- add RegExp support for checking "known" log messages
Script size changes
Totals
|
- fix eslint import error
- handle navigation on error (wip)
- remove console.log
- Remove unused files - restructure/rename components
- add "goto error" functionallity - setup all checks/sections with error fields
- fix bug that would case app to explode if invalid checktype was supplied
- enable `<ConfirmLeavingPage />` - remove unused code - update README.md
- add feature concept
- fix feature concept panic render
- add secrets to right aside
- fix word-break on log `msg`
- `adhoc-check`: handle use of `expect` - move components to own files - handle submit and submitting better
- handle form errors for adhoc checks
- fix: handle form errors for adhoc checks
- handle custom section labels - better handling of existing checks (edit)
This was referenced Oct 9, 2025
- handle custom section labels - better handling of existing checks (edit) - add tests
- handle custom section labels - better handling of existing checks (edit) - add tests
- handle custom section labels - better handling of existing checks (edit) - add tests
- handle custom section labels - better handling of existing checks (edit) - add tests
- add more tests
- fix active label bug
- add label limits to label section
- chore: migrate `traceroute` tests (new check)
- chore: migrate `dns` tests (new check)
- fix: typings after Combobox introduction
- fix: typings after Combobox introduction
- chore: disable adhoc check for Traceroute
- chore: add tests for `TCP` (new check) - chore: move v2 utils to a proper directory
- chore: add v2 CommonFields.payload.tests (new check)
- chore: add http check tests (new check) - fix: deprecation warning
ckbedwell
reviewed
Oct 28, 2025
- chore: add http check tests (new check) - fix: deprecation warning
- chore: add browser tests (new check)
- chore: add scripted tests (new check)
- chore: tests for edit check
- cr: move overflow
- cr: move overflow - fix: Feedback.tsx does not care about boundaries
- fix: incorrect icon for check logs
- fix: add Feedback placement prop
ckbedwell
reviewed
Oct 29, 2025
ckbedwell
approved these changes
Oct 29, 2025
Contributor
ckbedwell
left a comment
ckbedwell
left a comment
There was a problem hiding this comment.
LGTM 🎉 ⭐ 🌟 💪 - LFGooooooooooo 🎉🎉🎉🎉🎉
ckbedwell
dismissed
VikaCep’s stale review
On holiday and her comments have been addressed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked check editor for synthetic checks
Complete re-creation of the current check Form.
Why? As we require more features and customization of the Check form, it has become increasingly complex to do the simplest changes. In an attempt to simplify and surface inner workings, "everything" has been remade.
The name "Checkster" is a placeholder name that will later be refactored into "CheckEditor", as soon as we have removed the old "CheckEditor".
Features
This PR also brings new features to the check authoring view:
How to test
synthetic-monitoring-check-editorAdhoc check example (blackbox exporter)
Adhoc check example (k6/multihttp)
Adhoc check example (k6)
Additional context
Resolves #1263
Resolves #1174
Resolves #953
Resolves #1133