Use custom gateway ingress host in OpenShift tenant redirect URLs. - #1629
Open
akshitkumawat wants to merge 1 commit into
Open
Use custom gateway ingress host in OpenShift tenant redirect URLs.#1629akshitkumawat wants to merge 1 commit into
akshitkumawat wants to merge 1 commit into
Conversation
When spec.template.gateway.ingress.host is set, the OpenShift Route already uses that hostname, but tenants.yaml still used the generated Route FQDN for redirectURL. Derive both from the same effective gateway hostname. Signed-off-by: Akshit Kumawat <akshit2433@gmail.com>
Contributor
Signed commits report1 of 1 commit between
This repository requires all commits to be signed. See GitHub docs on commit signature verification. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.template.gateway.ingress.hostis set, the OpenShift gateway Route already uses that hostname, but OpenShift tenantredirectURLvalues intenants.yamlwere still built from the generated Route FQDN (tempo-<name>-gateway-<namespace>.<baseDomain>).Test plan
go test ./internal/manifests/gateway/https://<custom-host>/openshift/<tenant>/callbacknaming.RouteFqdnforredirectURL/openshift/dev/callback,/openshift/test/callback)