Migrate grafana_organization_preferences to use Framework SDK#2549
Draft
Migrate grafana_organization_preferences to use Framework SDK#2549
Conversation
Contributor
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
suntala
commented
Feb 24, 2026
| t := time.UnixMilli(annotation.Time) | ||
| tEnd := time.UnixMilli(annotation.TimeEnd) | ||
|
|
||
| // Convert tags to set; use null when empty so state matches plan (optional attribute unset). |
Contributor
Author
There was a problem hiding this comment.
CI fails without these annotation changes.
suntala
commented
Feb 24, 2026
| var err error | ||
|
|
||
| text := d.Get("text").(string) | ||
| panelID := int64(0) |
Contributor
Author
There was a problem hiding this comment.
CI fails without these annotation changes.
6cf3d2c to
83f4596
Compare
15 tasks
Contributor
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
c13efdf to
8671ffc
Compare
8671ffc to
8de88d8
Compare
be61d3d to
af7c8b8
Compare
Evidence: oss-other job 68893502828 had PUT /org/preferences 401 until old retry exhaustion (~8m). 8x2s often ends before Grafana propagates org membership. Use 15x3s (~42s max delay) — well under long loops yet enough for intermittent 401 after new org.
…test split) - Always apply WithOrgID on cloned client after resolving org id (parse or fallback). - Two-phase PUT when home_dashboard_uid is set (general prefs then full body). - Split TestAccResourceOrganizationPreferences: apply prefs without home dashboard UID before adding it (OSS acc 401 mitigation). - Keep NDJSON debug hooks for GRAFANA_ORG_PREFS_DEBUG_LOG until CI green.
- Org preferences: phased PUT retained; 2s settle on create for org_id!=1; retry 403 like 401 - Debug: NDJSON (.ndjson), repo mirror, tflog/CI artifact/summary; Update A log; unit test for debug write - CI: GRAFANA_PULL_POLICY wired to compose --pull; mysql pull_policy; integration docker-cache + retry - Makefile: export GRAFANA_PULL_POLICY for compose; integration-test passes pull policy to test.sh - test.sh: compose -f/--project-directory from repo root for correct volume paths - gitignore org-prefs-debug-42b169.ndjson
Keep org prefs debug artifact steps and add generic app platform matrix subset + TESTARGS from main.
Resolve acc-tests.yml: keep generic matrix/TESTARGS from main and org prefs debug artifact + summary steps from this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/deployment_tools/issues/493866