docs: clarify SAML AuthnRequest signing is implicitly supported when configuring certificate and private key#2665
Open
dennismdejong wants to merge 1 commit intografana:mainfrom
Conversation
…configuring certificate and private key
dennismdejong
requested review from
Jguer and
dmihai
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grafana_sso_settingsSAML configuration to clarify that SAMLAuthnRequestsigning is implicitly enabled when configuring the SP certificate (certificate/certificate_path) and private key (private_key/private_key_path) alongsidesignature_algorithm(fixes Add support for signing SAML authentication requests ingrafana_sso_settings#2515).sign_authn_requestsboolean, aligning with Grafana's underlying implementation which uses these fields to determine if signing is requested.What has been tested
make update-schemaandmake docsto re-generate the provider documentation.