Merged
Conversation
Contributor
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fc3223184
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgehrett
reviewed
Apr 10, 2026
jgehrett
left a comment
There was a problem hiding this comment.
I'm new to this codebase so asked Claude for some help. I only have a couple questions / suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Guide
This PR migrates
grafana_asserts_suppressed_assertions_configfrom SDKv2 to the Plugin Framework.resource_disabled_alert_config.go- standard Framework rewrite. Notable:disabledAlertConfigResourceholds*assertsapi.APIClientandint64 stackIDdirectly, injected viaConfigureidis a new computed attribute withUseStateForUnknown()(set tonameon read, consistent with other asserts resources)nameretainsRequiresReplace()— equivalent to the previousForceNew: truematch_labelsisschema.MapAttribute{ElementType: types.StringType}, populated withtypes.MapValueFromputhelper handles upsert viaPutDisabledAlertConfigreadhelper retains eventual-consistency retry viawithRetryRead(SDKv2helper/retryaliased assdkretry)ImportStateimplemented using thereadhelper rather thanresource.ImportStatePassthroughID, so import populates the full modeldocs/- generated;make docsproduces no changes to the asserts suppressed assertions config page.Issue ref
https://github.com/grafana/deployment_tools/issues/542767