feat(cloud_stack): add cloud_provider_url, connections_api_url, sm_url and simplify provider docs#2679
Open
feat(cloud_stack): add cloud_provider_url, connections_api_url, sm_url and simplify provider docs#2679
Conversation
Contributor
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
…m_url outputs Add computed URL attributes to the grafana_cloud_stack resource and data source so users can wire them directly to the provider config without manual URL construction: - cloud_provider_url: derived from cluster_slug - connections_api_url: derived from cluster_slug - sm_url: read from GCOM API (RegionSyntheticMonitoringApiUrl) Update provider docs to show the Terraform-native approach and remove the manual curl/jq alternatives.
Rewrite the provider-cloud.tf example to show a complete Grafana Cloud setup using only 2 provider blocks (cloud alias + default). Wire all service URLs from the stack resource outputs (including the new cloud_provider_url, connections_api_url, and sm_url attributes). Simplify templates/index.md.tmpl by removing 6 sections (Synthetic Monitoring installation, OnCall, Frontend O11y, Cloud Provider, Connections, Fleet Management) that duplicated individual resource docs. Update oncall_url and oncall_access_token descriptions in both framework and legacy providers to clarify they are only needed for OnCall OSS or dedicated tokens, not for Grafana Cloud usage. Also update replace_references.go with new cross-references generated from the updated example.
Duologic
force-pushed
the
duologic/moar_urls
branch
from
97d8946 to
9cc2bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grafana_cloud_stackresource and data source:cloud_provider_url,connections_api_url, andsm_url. These allow users to wire all Grafana Cloud service URLs directly from the stack output, matching the provider configuration attribute names exactly.cloudalias for Cloud API, one default for all other services).templates/index.md.tmplby removing 6 sections that duplicated individual resource documentation (Synthetic Monitoring installation, OnCall, Frontend O11y, Cloud Provider, Connections, Fleet Management).oncall_urlandoncall_access_tokenprovider attribute descriptions to explain they are only needed for OnCall OSS or dedicated tokens, not for Grafana Cloud usage.URL derivation
cloud_provider_urlcluster_slug:https://cloud-provider-api-{clusterSlug}.grafana.netconnections_api_urlcluster_slug:https://connections-api-{clusterSlug}.grafana.netsm_urlRegionSyntheticMonitoringApiUrlTest plan
grafana_cloud_stackresource and data source acceptance tests extended with regex-validated assertions for all three new URL attributes.go test ./... -run TestUnit).go generate ./...).