Limit deploy previews to mounted docs roots - #1477
Draft
jdbaldry wants to merge 7 commits into
Draft
Conversation
Contributor
Readability report
View metric targets
|
Contributor
|
💻 Deploy preview available (Serve redirects in deploy previews from the Hugo manifest): |
grafana/website#32512 replaces client-side alias pages with a generated redirects manifest. Previews serve dist directly, so without rewrites alias URLs would 404 once that change ships in docs-base. Generate dist/preview-redirects.conf after the Hugo build with the redirects binary already present in the docs-base image, and include it in the preview nginx server block. Older images have a redirects binary without the --manifest option, so fall back to scraping dist for alias pages, which preserves current behaviour. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Allows callers to test preview builds against docs-base images published from grafana/website pull requests with the build-docs-base label. The login only runs for us-docker.pkg.dev images and requires id-token permission from the caller, which the writers-toolkit caller already grants. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
force-pushed
the
jdb/deploy-preview
branch
from
July 24, 2026 20:42
bf6797a to
efb76aa
Compare
jdbaldry
marked this pull request as ready for review
July 24, 2026 20:44
Some interactive-tutorials paths omit layout in website.yaml, which makes deploy previews render in the default docs layout instead of the learning path layout. This adds a fallback in build-interactive-tutorials that writes layout: single-journey when website.yaml is missing or does not define layout. I did not change existing website.yaml values because preview generation should be resilient to incomplete package metadata. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
marked this pull request as draft
August 13, 2026 10:16
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Testing