Skip to content

FEATURE-66: The app should support grouping #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Feb 25, 2025
Merged

FEATURE-66: The app should support grouping #87

merged 45 commits into from
Feb 25, 2025

Conversation

grafviktor
Copy link
Owner

  • Add group UI input field to host edit form
  • Implement group list UI component which is used to selected a particular group

grafviktor and others added 30 commits November 11, 2024 22:39
@grafviktor grafviktor self-assigned this Feb 21, 2025
@grafviktor grafviktor linked an issue Feb 21, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 89.50893% with 47 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (fbc4932) to head (4f2db5d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/ui/model.go 40.74% 16 Missing ⚠️
internal/ui/component/hostlist/hostlist.go 92.50% 12 Missing and 3 partials ⚠️
internal/ui/component/grouplist/grouplist.go 92.22% 6 Missing and 1 partial ⚠️
internal/model/ssh/config.go 66.66% 2 Missing and 1 partial ⚠️
internal/ui/component/hostlist/host_delegate.go 89.65% 3 Missing ⚠️
internal/ui/component/grouplist/item.go 33.33% 2 Missing ⚠️
internal/ui/component/hostedit/hostedit.go 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
+ Coverage    80.10%   81.95%   +1.84%     
===========================================
  Files           24       27       +3     
  Lines         1674     2000     +326     
===========================================
+ Hits          1341     1639     +298     
- Misses         320      346      +26     
- Partials        13       15       +2     
Flag Coverage Δ
go-1.22.x 81.95% <89.50%> (+1.84%) ⬆️
go-1.23.x 81.95% <89.50%> (+1.84%) ⬆️
macOS 81.66% <89.50%> (+1.93%) ⬆️
ubuntu 81.66% <89.50%> (+1.93%) ⬆️
unit 81.95% <89.50%> (+1.84%) ⬆️
windows 80.71% <88.61%> (+1.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafviktor grafviktor force-pushed the feature/66 branch 9 times, most recently from aad4c84 to 3c95795 Compare February 21, 2025 16:41
@grafviktor grafviktor merged commit 0c58ee8 into develop Feb 25, 2025
10 checks passed
@grafviktor grafviktor deleted the feature/66 branch February 26, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Should support grouping
1 participant