Conversation
… conversion machinery This change makes it easier to use plist-yaml-plist as a library by giving callers a string instead of being forced to immediately write a file to disk.
Owner
|
Hi, can you take a look at the |
Author
Should I rebase on dev to see if the changes are still relevant? |
Owner
|
Yes please, if you can. It's different enough that I can't figure out what the original intention was. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it easier to use plist-yaml-plist as a library by giving callers back a string instead of writing automatically writing to a file. I already tested this change in my fork though please test yourself in case I am missing something. I am also happy to add a unit test if desired.
https://github.com/autopkg/discentem-recipes/blob/main/SharedProcessors/lib/plist_yaml_plist/plist_yaml.py#L109C1-L121C18