This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Multiple Project updates #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Spring auto-configuration was incorrectly set in the `boot-plugin`, causing misconfiguration issues. This commit ensures the correct auto-configuration is applied.
Corrected a typo in the package name grails-datastore-async in renovate.json to ensure proper dependency updates.
Update the GitHub workflows to the latest Grails repository standard and best practices.
…uration Fixed a Spring misconfiguration that caused MongoDbGormAutoConfigurationSpec to fail. This commit ensures the test runs correctly.
Moved shared build configuration logic into `*-config.gradle` files, enabling a more compositional approach to build setup.
Refactored `BsonPersistentEntityCodecSpec` to align with the updated API. The constructor `JsonWriterSettings(JsonMode)`` no longer exists, requiring adjustments to the test.
Refactored GlobalTemplateSpec to eliminate the use of Micronaut HttpClient, removing the project's dependency on it.
…erSpec` Removed the `@Ignore` annotation from two tests in `MongoDbDataStoreSpringInitializerSpec` since they are now passing, allowing them to run as part of the test suite.
Remove unused `grails-app` directory. The `application.yml` setting `grails.gorm.failOnError: false` seems to be a left-over from copy-pasting the `gorm-hibernate` plugin.
Update a test in `LocalMongoUnitSpec` to use `@PendingFeature` instead of `@Ignore`, allowing it to run while marking it as an expected failure until the issue is resolved.
Refactor `MongoSpec` to remove the deprecated `Package.getPackage()` call, ensuring compatibility with newer Java versions.
It looks like this file has been copy/pasted from another project.
- Adopt a composition-based build structure. - Integrate the Grails Publish Plugin. - Update dependencies and refine dependency scopes. - Add support for the `excludeUnusedTransDeps` flag to allow building and testing with unused transitive dependencies excluded.
- Update 7.0.14 to 7.0 which uses the latest 7.0.x version - Add mongodb server to groovy-joint-workflow.yml
- Switch to only use major version. - Add version 8.
jdaugherty
suggested changes
Feb 11, 2025
Contributor
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
Great work! I'll merge the docs updates & remove the rx gorm docs after we get this merged.
grails-plugin/src/main/groovy/grails/plugins/mongodb/MongodbGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-plugin/src/main/groovy/grails/plugins/mongodb/MongodbGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
Author and developer metadata have been removed from MongodbGrailsPlugin, as this information is not necessary for core plugins.
jdaugherty
approved these changes
Feb 12, 2025
Contributor
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
It looks like you also removed the author/developers reference. We've only been removing the email addresses, but I'm ok with removing these too. They're in the published artifact anyhow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages for detailed descriptions of each change.
Breaking change:
MongoSpecinorg.grails.plugins:mongodbhas been moved totestFixtures.