Fix publishing of snapshot docs #796
Conversation
The snapshot docs publishing step had a faulty condition that prevented execution. This commit removes the faulty condition along with cleaning up all other redundant step conditions.
| MAVEN_PUBLISH_PASSWORD: ${{ secrets.MAVEN_PUBLISH_PASSWORD }} | ||
| run: ./gradlew --no-build-cache publish | ||
| - name: "🔨 Build Docs" | ||
| id: docs |
There was a problem hiding this comment.
I usually see changes like if: success() on later steps for publish /docs. Is this workflow setup to fail fast / not continue on? If so, why do other projects have that check and we're removing all checks here?
There was a problem hiding this comment.
I think fail-fast applies to matrix jobs. When enabled, if any matrix job fails, all other matrix jobs are canceled immediately to save time and resources.
if: success() is the default behavior unless a previous step has continue-on-error: true. In typical cases, it is redundant because steps are sequential and stop on previous step failure by default.
There was a problem hiding this comment.
If so, why do other projects have that check and we're removing all checks here?
IDK
The snapshot docs publishing step had a faulty condition that prevented execution.
This commit removes the faulty condition along with cleaning up all other redundant step conditions.