fix(grainfmt): Correct formatting of single arc function callback #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that `type T = (a => b) => c` was being formatted to `type T = a => b => c` the formatter was seeing a single arugment and stripping the parameters however those are two completely different functions in grain as that is actually interpreted as `type T = a => (b => c)`. In order to fix this we simply don't strip the parenthesis on function types that accept a single function as their argument. Notes: * I changed the parameter name in the tests of another function just so the module validates properly.
spotandjake
requested review from
alex-snezhko,
ospencer and
phated
as code owners
ospencer
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
type T = (a => b) => cwas being formatted totype T = a => b => cthe formatter was seeing a single arugment and stripping the parameters however those are two completely different functions in grain as that is actually interpreted astype T = a => (b => c).In order to fix this we simply don't strip the parenthesis on function types that accept a single function as their argument.
Notes: