-
Notifications
You must be signed in to change notification settings - Fork 42
Update PYTHON_PATH in SUSE sign template #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls include a "Fixes" tag in the PR description that references the target issue (which'll later close it automatically).
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: )
templates/suse/Dockerfile.sign.template
line 15 at r1 (raw file):
{% endblock %} {% block path %} {{- python_path('/lib64') -}}{% endblock %}
pls add hyphens ({%-
) to align with the other sign templates
Code quote:
{%
Signed-off-by: Davis Benny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated description.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @kailun-qin)
templates/suse/Dockerfile.sign.template
line 15 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
pls add hyphens (
{%-
) to align with the other sign templates
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
Description of the changes
Fixes #236 issue.
How to test this PR?
This change is