fix: elaborate on configuring search index - #53
Open
qugu wants to merge 1 commit into
Open
Conversation
Follow-up on: https://gramps.discourse.group/t/ai-chat-with-openai-returns-an-error-on-successfull-call/8735/4 It might be better to call "enable" -> "configure" because that's what happens and then actually trigger the rebuild in the web UI
Member
|
Hmm... but if the model is not configured, semantic search is really disabled in the sense that the search page will not show the full-text/semantic toggle button. So I'm not sure this is clearer. But you're right, we enable it by configuring it (this is what was originally meant with "enabling ... can be as simple as setting the configuration option". Perhaps a combination? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on: https://gramps.discourse.group/t/ai-chat-with-openai-returns-an-error-on-successfull-call/8735/4
It might be better to call "enable" -> "configure" because that's what happens and then actually trigger the rebuild in the web UI