Fix memory leak caused by stale link tags in GuiGramplet#2353
Open
ztlxltl wants to merge 1 commit into
Open
Conversation
Member
|
Did you intend this to target the gramps61 branch? |
Contributor
Author
|
I wasn't sure which version this bug should ideally be fixed in. I'm happy to change it if you prefer 6.1. |
Member
|
There will be no further releases in the gramps60 branch. |
82ec909 to
898e46e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce the leak:
The reason for the delays is that
PedigreeGramplet.gui._tagsis never cleared, but new tags are added every time the content is updated.This PR fixes this by:
GuiGramplet._tagsto an empty list inGuiGramplet.clear_text()GuiGramplet.clear_text()inGuiGramplet.set_textGramplet.clear_text()inPedigreeGramplet.main()(
Gramplet.clear_text()callsGuiGramplet.clear_text())I couldn't find a bug report about this. I'm happy to create one if a discussion about this is preferred.