Skip DISPLAY check test locally if GDK_BACKEND=-#2367
Open
hgohel wants to merge 1 commit into
Open
Conversation
Unit test `test_consistent_with_DISPLAY_env` fails on Ubuntu 24.04 when `GDK_BACKEND=-` is set, and passes when it isn't. This doesn't happen on GitHub in Gramps CI environment and the difference is that locally DISPLAY is set causing the test to fial, whereas on GitHub Gramps CI, DISPLAY is not set, allowing the test to pass. To work around this, this test is skipped when GDK_BACKEND=- because that deliberately overrides display detection.
Member
Author
|
Output before code change: Failure with GDK_BACKEND=-
Pass without GDK_BACKEND
In both cases, the shell has these set: Verified that with the fix the test is skipped when the env var is set, and executed when not set: Output after code change
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit test
test_consistent_with_DISPLAY_envfails on Ubuntu 24.04 whenGDK_BACKEND=-is set, and passes when it isn't.This doesn't happen on GitHub in Gramps CI environment and the difference is that locally DISPLAY is set causing the test to fail, whereas on GitHub Gramps CI, DISPLAY is not set, allowing the test to pass.
To work around this, this test is skipped when GDK_BACKEND=- because that deliberately overrides display detection.