Toolbar Edit labels now consistent per GNOME HIG (bug 6583)#2434
Open
eduralph wants to merge 1 commit into
Open
Conversation
Per the GNOME Human Interface Guidelines, a trailing ellipsis means "this command needs further input from the user before it can act". The Edit action opens an existing record in its editor (a state/properties window), so it must not carry an ellipsis. Add and Merge keep theirs, as they open dialogs that require user input before acting. Drop the trailing ellipsis from Edit toolbar/menu/popup labels in 11 list-view and category-view source files (32 label sites total). Other ellipsis labels (Add, Merge, etc.) correctly retain theirs per the Input-Required rule. Fixes #6583 Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User impact: The "Edit" command in the toolbar, menus, and right-click popups shows a trailing "…" (three dots), which by convention promises the command will first ask you for more input. But choosing Edit just opens the selected record straight away — so the dots are misleading and inconsistent with how the rest of Gramps behaves.
This drops the trailing "…" from every Edit label so it reads simply "Edit", matching what the command actually does.
Reported in Mantis #6583.
What to look at
Every Edit action across the list and category views loses its trailing ellipsis, while Add and Merge keep theirs (they do open input dialogs). To see it: right-click a person (or any list record) and note the context-menu "Edit" entry, plus the toolbar and menu — all now read "Edit" with no dots.
Root cause
The GNOME Human Interface Guidelines specify that a trailing ellipsis ("…") indicates "this command needs further input from the user before it can act". The Edit action opens the selected record in its editor without prompting for additional input—it is a state/properties window, not an input-required dialog—so its labels must not carry an ellipsis.
Fix
Remove the trailing ellipsis from all Edit toolbar/menu/popup labels across 11 list-view and category-view files (32 label sites total), while leaving Add and Merge labels unchanged—they correctly retain their ellipsis because they open input-requiring dialogs.
Verification
gramps/plugins/lib/libpersonview.py:271,348,430— Edit label changed from "Edit..." to "Edit" in menu, toolbar, and popupgramps/plugins/lib/libplaceview.py:347,406,485— Edit labels consistent with same patterngramps/plugins/view/citationlistview.py:234,293,365— same three-site pattern (menu, toolbar, popup)gramps/plugins/view/citationtreeview.py:385,466,554— consistent Edit label removalgramps/plugins/view/eventview.py:247,306,378— consistent patterngramps/plugins/view/familyview.py:204,263,348— consistent patterngramps/plugins/view/mediaview.py:311,370,472— consistent patterngramps/plugins/view/noteview.py:193,252,324— consistent patterngramps/plugins/view/repoview.py:229,288,360— consistent patterngramps/plugins/view/sourceview.py:201,260,332— consistent patterngramps/plugins/view/relview.py:414,504— Edit labels in popup and toolbar (two sites for this file)po/POTFILES.skip— test file registered in skip list (no translatable strings)gramps/plugins/test/toolbar_label_ellipsis_test.py(new) — reads each view's source file (headless-safe, no GTK import) and asserts that all Edit action labels extracted from both toolbar XML literals and sgettext forms do not end with "…". RED before the patch (Edit… present in all 11 files) and GREEN after (Edit only, no ellipsis). A second assertion guards against vacuous parser success by verifying ≥1 Edit label is found in each listed file.Fixes #6583