Add check for stale files in POTFILES.in#2460
Open
hgohel wants to merge 3 commits into
Open
Conversation
When` intltool-update -m` finds file entries in POTFILES.in which no longer exist, it logs those to `notexist`. If that file is file, CI will now treat that as an error as well.
hgohel
added
Type: Infrastructure
Status: New
Member
Author
|
@Nick-Hall CI check failed installing dependencies...a transient error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
intltool-update -mfinds file entries in POTFILES.in which no longer exist, it logs those tonotexist. If that file is found, CI will now treat that as an error in addition to the new file test.It's interesting that the man page for intltool-update does not mention this scenario, but I found that to be the behavior and Claude confirmed it.
Please squash-and-merge.