Review classic camera system for main branch#76
Merged
grandixximo merged 1 commit intoOct 11, 2025
Conversation
|
Cursor Agent can help with this pull request. Just |
cursor
Bot
force-pushed
the
cursor/review-classic-camera-system-for-main-branch-5d52
branch
2 times, most recently
from
c5b8765 to
e8255b9
Compare
Port camera system improvements from classic branch (commit 26d8dcf): - Add SetPreviewVisibility() to control preview without rebuilding DirectShow graph - Implement UpdatePreviewWindow() to switch window owners efficiently - Use lazy initialization pattern for camera capture - Hide/show preview instead of dispose/recreate on visibility changes Benefits: - 3-5x faster when switching between views with webcam preview - Eliminates flicker during UI transitions - Better resource management with deferred initialization - Fewer DirectShow errors from graph rebuild cycles Co-authored-by: toniolo.luca <toniolo.luca@outlook.com>
cursor
Bot
force-pushed
the
cursor/review-classic-camera-system-for-main-branch-5d52
branch
from
e8255b9 to
2a4c3b7
Compare
grandixximo
deleted the
cursor/review-classic-camera-system-for-main-branch-5d52
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port camera opening system improvements from classic branch to enhance performance and user experience.
The previous system frequently rebuilt the DirectShow camera graph when the webcam preview visibility changed or the window owner switched, leading to visible flicker, performance degradation, and unnecessary resource churn. This PR introduces methods to control preview visibility and switch window owners without rebuilding the graph, along with lazy camera initialization, resulting in a smoother, more efficient, and reliable camera experience.