Fix missing localization for Admin.Catalog.Products.Pictures.Fields.IsDefault - #723
Merged
Merged
Conversation
…alization key Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix localization issue for picture details
Fix missing localization for Admin.Catalog.Products.Pictures.Fields.IsDefault
Jul 4, 2026
KrzysztofPajak
marked this pull request as ready for review
July 5, 2026 16:21
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing English localization entry so the “Is default” checkbox label for product pictures renders as a human-readable string instead of the raw resource key (Admin.Catalog.Products.Pictures.Fields.IsDefault) in the admin (and any other UI surfaces using that key).
Changes:
- Added the missing
Admin.Catalog.Products.Pictures.Fields.IsDefaulttranslation resource to the 2.2 upgrade English resource file (en_220.xml).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Is default" checkbox in the Picture details popup renders the raw resource key
Admin.Catalog.Products.Pictures.Fields.IsDefaultinstead of a human-readable label, as visible in the screenshot above.Root Cause
ProductPictureModel.IsDefaultis decorated with[GrandResourceDisplayName("Admin.Catalog.Products.Pictures.Fields.IsDefault")]in bothGrand.Web.AdminSharedandGrand.Web.Vendormodels, but this key was never registered in any localization resource file.Change
src/Web/Grand.Web/App_Data/Resources/Upgrade/en_220.xml— adds the missing entry: