Skip to content

Fix missing localization for Admin.Catalog.Products.Pictures.Fields.IsDefault - #723

Merged
KrzysztofPajak merged 2 commits into
developfrom
copilot/fix-picture-details-localization
Jul 5, 2026
Merged

Fix missing localization for Admin.Catalog.Products.Pictures.Fields.IsDefault#723
KrzysztofPajak merged 2 commits into
developfrom
copilot/fix-picture-details-localization

Conversation

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

The "Is default" checkbox in the Picture details popup renders the raw resource key Admin.Catalog.Products.Pictures.Fields.IsDefault instead of a human-readable label, as visible in the screenshot above.

Root Cause

ProductPictureModel.IsDefault is decorated with [GrandResourceDisplayName("Admin.Catalog.Products.Pictures.Fields.IsDefault")] in both Grand.Web.AdminShared and Grand.Web.Vendor models, but this key was never registered in any localization resource file.

Change

  • src/Web/Grand.Web/App_Data/Resources/Upgrade/en_220.xml — adds the missing entry:
<Resource Name="Admin.Catalog.Products.Pictures.Fields.IsDefault" Area="Admin">
    <Value>Is default</Value>
</Resource>

…alization key

Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix localization issue for picture details Fix missing localization for Admin.Catalog.Products.Pictures.Fields.IsDefault Jul 4, 2026
Copilot AI requested a review from KrzysztofPajak July 4, 2026 23:16
@KrzysztofPajak
KrzysztofPajak marked this pull request as ready for review July 5, 2026 16:21
Copilot AI review requested due to automatic review settings July 5, 2026 16:21
@KrzysztofPajak
KrzysztofPajak merged commit 524320b into develop Jul 5, 2026
5 of 7 checks passed
@KrzysztofPajak
KrzysztofPajak deleted the copilot/fix-picture-details-localization branch July 5, 2026 16:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missing English localization entry so the “Is default” checkbox label for product pictures renders as a human-readable string instead of the raw resource key (Admin.Catalog.Products.Pictures.Fields.IsDefault) in the admin (and any other UI surfaces using that key).

Changes:

  • Added the missing Admin.Catalog.Products.Pictures.Fields.IsDefault translation resource to the 2.2 upgrade English resource file (en_220.xml).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picture details Localization is not working [Admin.Catalog.Products.Pictures.Fields.IsDefault]

3 participants