FIELD_HISTORY_OBJECT_ID_TYPE not working with django-configurations#33
Open
sreyemnayr wants to merge 1 commit into
Open
FIELD_HISTORY_OBJECT_ID_TYPE not working with django-configurations#33sreyemnayr wants to merge 1 commit into
sreyemnayr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not certain if this was exclusive to django-configurations, but setting FIELD_HISTORY_OBJECT_ID_TYPE = models.IntegerField caused it to error out because an instance of the class was being passed, not the class itself. This hotfix checks to see if that's what's being passed first and converts it back to the class if that's the case.