Fix np.byte dtype in dataset_readers.py — breaks PIL with NumPy 2.x#1330
Open
i-am-mushfiq wants to merge 1 commit into
Open
Fix np.byte dtype in dataset_readers.py — breaks PIL with NumPy 2.x#1330i-am-mushfiq wants to merge 1 commit into
i-am-mushfiq wants to merge 1 commit into
Conversation
Image.fromarray() requires unsigned uint8 for RGB images. np.byte is signed int8, which raises "Cannot handle this data type: |i1" under NumPy 2.x (and silently produces wrong colors on NumPy 1.x). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scene/dataset_readers.pyusesdtype=np.bytewhen constructing an RGB image array:np.byteis a signed int8 type.Image.fromarray()expects unsigned uint8 for RGB images. This raises:This error surfaces on NumPy 2.x, which enforces stricter dtype checking. On NumPy 1.x the signed type was silently accepted but still technically incorrect (values above 127 would overflow to negative).
Fix
One character change:
np.byte→np.uint8.Impact
Affects anyone loading Blender synthetic (NeRF format) datasets (
readNerfSyntheticInfo) with images that have an alpha channel, when using NumPy 2.x.🤖 Generated with Claude Code