Add an option to terminate all existing connections to the database when resetting a database #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
reviewed
Mar 14, 2025
| ); | ||
| if (force) { | ||
| await pgClient.query( | ||
| `DROP DATABASE IF EXISTS ${escapeIdentifier(databaseName)} WITH (FORCE);`, |
There was a problem hiding this comment.
Introduced in PG13, so this is technically supported by all supported versions of PostgreSQL now. Interesting.
|
Thanks for the PR... I shall search my feelings 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
--forceoption for thegraphile-migrate resetcommand, which allows terminating existing connections to the database when dropping it.I often face a case during end-to-end testing when before each test case I want to reset the database. Unfortunately due to some lingering connections from previous tests, the
graphile-migrate resetcommand sometimes throws an error as expected. This change allows to bypass that limitation.Performance impact
Unknown.
Security impact
Unknown.
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).