Conversation
lmeyerov
force-pushed
the
issue-1395-reply-author-row-shaping-join
branch
from
a528150 to
7456341
Compare
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MATCHclauses with relationship patterns by adding a safe merge fallback when node-only seed binding does not applyrecent-repliessequentialMATCHshapemessage-repliessequentialMATCHshapeWhy
Issue #1395 tracks residual adapter-based row shaping for reply-author lanes. A direct repro showed sequential two-
MATCHquery forms failing compile-time with:Only node-only pre-binding MATCH clauses are supported before the final connected MATCH in this phase.Equivalent single-
MATCHcomma patterns already worked; this patch closes that compiler gap.Validation
python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "issue_1395 or issue_996"python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "connected_multi_pattern or issue_1395 or issue_996 or recent_message_reentry"uv run ruff check graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.pyIssue
Closes #1395