Fix version comparison logic for Python >= 3.8 in log.py #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the version was compared as a string, but that could lead to an error (e.g. '3.11.0' < '3.8.0'), which could cause incorrect behaviour. Now it compares sys.version_info[:3] tuples to ensure correct numeric comparison and prevent false warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The previous implementation compared Python versions as strings, which could lead to incorrect behavior. For example,
'3.11.0' < '3.8.0'evaluates toTruedue to lexicographical ordering.Solution
This commit modifies the version comparison to use
sys.version_info[:3], which provides a tuple of the major, minor, and micro components of the Python version. This ensures a correct numeric comparison.Testing
Tested the change on Python versions 3.8 to verify correct behavior.