Skip to content

Conversation

@piotr1212
Copy link
Member

removes warnings
UserWarning: Unknown distribution option: 'install_requires'
UserWarning: Unknown distribution option: 'long_description_content_type'

setuptools seems to be the recommended way now.

removes warnings
UserWarning: Unknown distribution option: 'install_requires'
UserWarning: Unknown distribution option: 'long_description_content_type'

setuptools seems to be the recommended way now.
@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #272 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files           2        2           
  Lines        1113     1113           
  Branches      156      156           
=======================================
  Hits          979      979           
  Misses         94       94           
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad48a5b...cbd6584. Read the comment docs.

@deniszh
Copy link
Member

deniszh commented Jan 7, 2019

👍
Question - what we going to do with carbon and graphite-web?
I mean, now we use this - https://github.com/graphite-project/carbon/blob/6d4417739eab522d74084ea153d5b72cf367ec5d/setup.py#L53-L58

@deniszh
Copy link
Member

deniszh commented Jan 7, 2019

We can also revert that pesky GRAPHITE_NO_PREFIX=True logic too... not directly related, though.

@piotr1212
Copy link
Member Author

piotr1212 commented Jan 8, 2019 via email

@piotr1212
Copy link
Member Author

see graphite-project/carbon#835

@piotr1212
Copy link
Member Author

This one can already be merged, still writing docs and testing for carbon and web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants