feat: invert cuts to keep meaning consistent with pre-horizon #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Migone <[email protected]>
src/mappings/staking.ts
Outdated
Comment on lines
54
to
66
| export function handleDelegationParametersUpdated(event: DelegationParametersUpdated): void { | ||
| let graphNetwork = createOrLoadGraphNetwork(event.block.number, event.address) | ||
| let indexer = createOrLoadLegacyIndexer(event.params.indexer, event.block.timestamp) | ||
| indexer.indexingRewardCut = event.params.indexingRewardCut.toI32() | ||
| indexer.queryFeeCut = event.params.queryFeeCut.toI32() | ||
| indexer.delegatorParameterCooldown = event.params.cooldownBlocks.toI32() | ||
| indexer.lastDelegationParameterUpdate = ( | ||
| addresses.isL1 ? event.block.number : graphNetwork.currentL1BlockNumber! | ||
| ).toI32() | ||
| indexer = updateAdvancedIndexerMetrics(indexer as Indexer) | ||
| indexer.save() | ||
| } | ||
|
|
There was a problem hiding this comment.
I would not delete this at all, since we essentially lose historical tracking of delegation cuts. Particularly given that we are now moving all of the new delegation cuts to line up with these ones 😅
Comment on lines
+229
to
+231
| provision.queryFeeCut = BigInt.fromI32(1000000) | ||
| provision.indexingFeeCut = BigInt.fromI32(1000000) | ||
| provision.indexingRewardsCut = BigInt.fromI32(1000000) |
There was a problem hiding this comment.
Do we want to move all delegation cuts to the legacy version? Or do we keep Provision level ones lined up with Horizon, and Indexer level ones lined up with Legacy?
I think the latter is better, since it allows the UIs to move to "Stage 2"-like cuts or keep Legacy cuts by using different entities, and keeping both as Legacy just means that once we move to a more generic network subgraph (Stage 2) we'll have extra work that needs to be timed correctly
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.