Skip to content

feat: invert cuts to keep meaning consistent with pre-horizon #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented May 8, 2025

No description provided.

@juanmardefago juanmardefago force-pushed the tmigone/invert-cuts branch from afd4619 to 82fbc57 Compare May 16, 2025 17:49
@juanmardefago juanmardefago changed the base branch from juanmardefago/horizon-stage-1 to juanmardefago/horizon-stage-1-signed May 16, 2025 17:49
@juanmardefago
Copy link
Collaborator

@tmigone this should be in line with the discussions we had around this topic last time.
Legacy cuts should obey legacy logic (cut that the indexer takes), and are now all prefixed with legacy. Stuff that depended on that value should now use the legacy one for legacy code (i.e. on al non-horizon files), as well as the need for a full refactor of advanced metrics on legacy code, since there was also the effective cuts, and some advanced metrics that needed to be split into legacy vs horizon versions (otherwise they wouldn't have made sense)

@juanmardefago juanmardefago merged commit e8f5971 into juanmardefago/horizon-stage-1-signed May 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants