release branch for v0.23.6#1115
Closed
dwerner wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the release branch for v0.23.6 by updating network identifier resolution and registry mapping logic, renaming initialization functions, and updating test fixtures and documentation.
- Refactors network identifier resolution in both network connection and contract initialization flows
- Renames the registry initialization function from common_init to initNetworkRegistryESM and streamlines CAIP2 mappings
- Updates test fixtures and documentation to support the "hardhat" network and version bumps
Reviewed Changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/indexer-common/src/network.ts | Updates network identifier resolution and connection consistency |
| packages/indexer-common/src/indexer-management/types.ts | Refactors CAIP2 mapping logic and updates resolveChainId implementation |
| packages/indexer-common/src/indexer-management/monitor.ts | Removes outdated TODO regarding network presence in epoch subgraph |
| packages/indexer-common/src/tests/* | Adjusts networkIdentifier values in various test files |
| packages/indexer-common/src/tests/global-setup.ts | Switches to the new initNetworkRegistryESM function |
| packages/indexer-agent/src/commands/start.ts | Updates network identifier resolution and registry initialization |
| docs/networks/arbitrum-sepolia.md | Bumps version numbers to reflect v0.23.6 changes |
Files not reviewed (4)
- lerna.json: Language not supported
- packages/indexer-agent/package.json: Language not supported
- packages/indexer-cli/package.json: Language not supported
- packages/indexer-common/package.json: Language not supported
Comments suppressed due to low confidence (2)
packages/indexer-common/src/network.ts:553
- The updated check now compares resolveChainId(networkIdentifier) to networkIdentifier directly. It may not properly validate the contract connection if the networkIdentifier provided in a numeric format (e.g. extracted chainId) is meant to be resolved differently; please verify that this change correctly catches inconsistent inputs.
if (resolveChainId(networkIdentifier) !== networkIdentifier) {
packages/indexer-common/src/indexer-management/types.ts:215
- The new implementation of resolveChainId only checks for a valid CAIP2 string or a chain alias. Consider whether numeric inputs (or strings with only a number) might need different handling or explicit conversion to the 'eip155:' format to avoid resolution failures.
export function resolveChainId(caip2IdOrAlias: string): string {
e3d4233 to
09b4a29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.