definition: adds GetNullable unit tests.

[chris-ramon]

Description

• definition: adds GetNullable unit tests.

Test Plan

• Unit tests.

Summary by CodeRabbit

• Tests
  • Improved test coverage for nullable type handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A new test function TestGetNullable has been added to definition_test.go using a table-driven approach. The test verifies that the GetNullable function correctly unwraps underlying types from NonNull wrappers across scalar, object, and list types.

Changes

Cohort / File(s)	Summary
Test additions definition_test.go	Added TestGetNullable function with table-driven test scenarios validating GetNullable behavior for scalar, object, and list types wrapped in NonNull

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Straightforward table-driven test addition with repetitive structure
• Review focuses on validating test case correctness and coverage of the three type categories (scalar, object, list)

Poem

🐰 A tester's delight, oh what a sight,
GetNullable now shines in the test light,
From scalars to objects, to lists wrapped tight,
NonNull types unwrapped—everything's right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding unit tests for the GetNullable function in the definition package.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue-issue-731

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

definition_test.go (1)

800-850: LGTM! Well-structured test coverage for GetNullable.

The table-driven test correctly validates the core behavior of GetNullable for unwrapping NonNull types and pass-through of already-nullable types. The test structure follows Go best practices with descriptive names and clear assertions.

Optional: Consider additional edge case coverage

While the current test coverage is solid, you might optionally consider adding these edge cases for more comprehensive coverage:

1. nil input: Test behavior when nil is passed to GetNullable
2. List of NonNull elements: Verify that List(NonNull(Scalar)) returns the List itself (only outer NonNull should be unwrapped)
3. Other GraphQL types: Interface, Union, Enum, and InputObject types for completeness

Example additional test cases:

{
    name:     "List of NonNull elements should return List",
    ttype:    graphql.NewList(graphql.NewNonNull(scalarType)),
    expected: graphql.NewList(graphql.NewNonNull(scalarType)),
},
{
    name:     "Interface should return Interface",
    ttype:    graphql.NewInterface(graphql.InterfaceConfig{Name: "TestInterface"}),
    expected: graphql.NewInterface(graphql.InterfaceConfig{Name: "TestInterface"}),
},

These are purely optional enhancements and can be deferred if not needed immediately.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ca1f2d and d4e5a87.

📒 Files selected for processing (1)

• definition_test.go (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

definition_test.go (2)

definition.go (4)

• NewList (1248-1258)
• Type (13-18)
• NewNonNull (1299-1309)
• GetNullable (154-159)

language/ast/types.go (3)

• NewList (52-61)
• Type (7-11)
• NewNonNull (82-91)