update support ticket to support categories, project, and target options #6689
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| hasPreviousPage: false, | ||
| startCursor: '', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
youll want to remove these stubs. This was just for offline development.
| @@ -30,6 +30,9 @@ export default gql` | |||
|
|
|||
| input SupportTicketCreateInput { | |||
| organizationSlug: String! | |||
| project: String | |||
| target: String | |||
| category: SupportCategory! | |||
There was a problem hiding this comment.
Minor: I defer to my colleagues, but I think we should default this or make it nullable to avoid taking any downtime during the deployment window.
We don't get a ton of support tickets so I doubt it'd cause an issue, but I'm extra cautious.
| <> | ||
| <div className="italic text-gray-500">/</div> | ||
| {showOrganization ? <div className="italic text-gray-500">/</div> : <></>} |
There was a problem hiding this comment.
can use null instead of an empty element <></>
| onValueChange={ | ||
| onValueChangeFunc | ||
| ? id => { | ||
| onValueChangeFunc(id); |
There was a problem hiding this comment.
minor: to clean up the jsx, I'd move this defaulting logic to the top of the function alongside the other defaulting logic. And you shouldnt need to wrap the onValueChangeFunc
| </SelectItem> | ||
| ))} | ||
| ) : ( | ||
| <></> |
| </SelectItem> | ||
| )) | ||
| ) : ( | ||
| <></> |
| > | ||
| <SelectTrigger variant="default" data-cy="project-picker-trigger"> | ||
| <div className="font-medium" data-cy="project-picker-current"> | ||
| {currentProject.slug} | ||
| {optional ? <SelectValue placeholder="Pick an option" /> : ''} |
There was a problem hiding this comment.
minor: This can be shortened to
{optional ? <SelectValue placeholder="Pick an option" /> : (currentProject?.slug ?? '')}
| ) : ( | ||
| <div className="h-5 w-48 max-w-[200px] animate-pulse rounded-full bg-gray-800" /> | ||
| <></> |
| ) : ( | ||
| <div className="h-5 w-48 max-w-[200px] animate-pulse rounded-full bg-gray-800" /> | ||
| <></> |
| )} | ||
| <div className="italic text-gray-500">/</div> | ||
| {targets?.length && currentOrganization && currentProject && currentTarget ? ( | ||
| {showProject ? <div className="italic text-gray-500">/</div> : <></>} |
| > | ||
| <SelectTrigger variant="default" data-cy="target-picker-trigger"> | ||
| <div className="font-medium" data-cy="target-picker-current"> | ||
| {currentTarget.slug} | ||
| {isOptional ? <SelectValue placeholder="Pick an option" /> : ''} | ||
| {currentTarget && !isOptional ? currentTarget.slug : ''}{' '} |
There was a problem hiding this comment.
^ simplify like the prior comment
| <ProjectSelector | ||
| currentOrganizationSlug={props.organizationSlug} | ||
| currentProjectSlug={field.value ? field.value : ''} | ||
| onValueChange={(value: any) => { |
There was a problem hiding this comment.
avoid using any if possible.
Background
Updated the support ticket to include categories as well as optionally allow selection of the project and target.
#6622
Description
Update the TargetSelector and ProjectSelector
Update the Ticket page to allow for selection of the Target, Project, and Category
Update the mutation for new tickets to support the category, target, and project changes.
network sends the new inputs but I can't test further