Skip to content

Conversation

@eddeee888
Copy link
Collaborator

@eddeee888 eddeee888 commented Dec 24, 2025

Background

This PR integrates the major version of typescript-operations and client-preset in dotansimha/graphql-code-generator#10479.

This version keeps the config tighter, and avoids using typescript plugin altogether.

Description

TODO

Result

File Before (LOCs) After (LOCs) Change
packages/web/app/src/gql/graphql.ts 9869 4043 -59%
packages/libraries/core/src/client/__generated__/types.ts 1241 76 -93%

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @eddeee888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on integrating the major alpha versions of key GraphQL Code Generator dependencies. The primary goal is to leverage the latest advancements in typescript-operations and client-preset to achieve a more streamlined configuration and remove the dependency on the standalone typescript plugin. This change prepares the project for future stability and improved development workflows within the GraphQL ecosystem.

Highlights

  • Dependency Updates: Upgraded several @graphql-codegen packages to their latest alpha major versions, including cli, client-preset, typescript, typescript-operations, and typescript-resolvers.
  • Configuration Streamlining: This update aims to enable a tighter configuration setup and eliminate the need for the separate typescript plugin, aligning with the major version changes in typescript-operations and client-preset.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates @graphql-codegen packages to alpha versions, which introduces significant stability risks. It's recommended to use stable releases. The PR description also mentions removing the typescript plugin, but the codegen.mts file is unchanged. Given the 'TODO' in the description, this PR appears to be a work-in-progress.

package.json Outdated
Comment on lines 67 to 71
"@graphql-codegen/cli": "6.0.3-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3",
"@graphql-codegen/client-preset": "6.0.0-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3",
"@graphql-codegen/typescript": "6.0.0-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3",
"@graphql-codegen/typescript-operations": "6.0.0-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3",
"@graphql-codegen/typescript-resolvers": "5.1.3-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using alpha versions for these packages introduces a high risk of instability and bugs. It is strongly recommended to revert to stable versions, especially for a main branch. If this is for testing, it should be isolated to a feature branch.

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.46.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.57.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.19.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.1-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.46.1-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
hive 8.14.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
hive-apollo-router-plugin 2.3.6-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎
hive-console-sdk-rs 0.2.3-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7457.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 3461bba8edd7b8f0767144d10b1393e38b6560d9

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

💻 Website Preview

The latest changes are available as preview in: https://pr-7457.hive-landing-page.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant