-
Notifications
You must be signed in to change notification settings - Fork 124
Use alpha versions for typescript-operations major
#7457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @eddeee888, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on integrating the major alpha versions of key GraphQL Code Generator dependencies. The primary goal is to leverage the latest advancements in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates @graphql-codegen packages to alpha versions, which introduces significant stability risks. It's recommended to use stable releases. The PR description also mentions removing the typescript plugin, but the codegen.mts file is unchanged. Given the 'TODO' in the description, this PR appears to be a work-in-progress.
package.json
Outdated
| "@graphql-codegen/cli": "6.0.3-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3", | ||
| "@graphql-codegen/client-preset": "6.0.0-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3", | ||
| "@graphql-codegen/typescript": "6.0.0-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3", | ||
| "@graphql-codegen/typescript-operations": "6.0.0-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3", | ||
| "@graphql-codegen/typescript-resolvers": "5.1.3-alpha-20251125123407-8babe46fb9b33e9f9a377cd50c9580282e7981d3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.46.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.57.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.19.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.1-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.46.1-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
hive |
8.14.0-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
hive-apollo-router-plugin |
2.3.6-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
hive-console-sdk-rs |
0.2.3-alpha-20251224112211-3461bba8edd7b8f0767144d10b1393e38b6560d9 |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7457.hive-storybook.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7457.hive-landing-page.pages.dev |
3461bba to
b85d6f3
Compare
b85d6f3 to
1585870
Compare
Background
This PR integrates the major version of
typescript-operationsandclient-presetin dotansimha/graphql-code-generator#10479.This version keeps the config tighter, and avoids using
typescriptplugin altogether.Description
TODO
Result
packages/web/app/src/gql/graphql.tspackages/libraries/core/src/client/__generated__/types.ts