-
Notifications
You must be signed in to change notification settings - Fork 124
Move hive-console-sdk-rs to Hive Router repository #7476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kamilkisiela, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort by migrating the project's GraphQL parsing infrastructure from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/cli |
0.57.2-alpha-20260115082533-8f684a1572e75ff0d06e8c840d943f001a781368 |
npm ↗︎ unpkg ↗︎ |
hive |
9.0.0-alpha-20260115082533-8f684a1572e75ff0d06e8c840d943f001a781368 |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the codebase to use a forked version of graphql-tools instead of graphql-parser. My main feedback concerns the use of a git dependency pointing to a branch, which can impact build reproducibility; I recommend pinning it to a specific commit hash. Additionally, there's a minor performance improvement opportunity by removing an unnecessary clone.
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7476.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7476.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
80327e1 to
ea18b41
Compare
0bb48e2 to
645fea6
Compare
Changes:
hive-console-sdkmoved to/routerrepositoryapollo-router-hivedepends onhive-console-sdkcrate (via crates, not local dependency)apollo-router-hiveusesgraphql-tools::parserinstead ofgraphql-parser(as we now own the parser)It's a draft until the new versions of
hive-console-sdkandgraphql-toolscrates are released. When they are:hive-console-sdkandgraphql-toolsdependencies to depend on concrete version on crates.io