Skip to content

Conversation

@kamilkisiela
Copy link
Contributor

@kamilkisiela kamilkisiela commented Jan 9, 2026

Changes:

  • hive-console-sdk moved to /router repository
  • apollo-router-hive depends on hive-console-sdk crate (via crates, not local dependency)
  • apollo-router-hive uses graphql-tools::parser instead of graphql-parser (as we now own the parser)

It's a draft until the new versions of hive-console-sdk and graphql-tools crates are released. When they are:

  • switch hive-console-sdk and graphql-tools dependencies to depend on concrete version on crates.io

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kamilkisiela, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort by migrating the project's GraphQL parsing infrastructure from the graphql-parser crate to the graphql-tools crate. This change aims to standardize and potentially enhance GraphQL schema and query processing by leveraging a unified tooling library. The modifications span across dependency management files and core Rust source code, ensuring a complete transition to the new parsing library.

Highlights

  • Dependency Update: Replaced the graphql-parser crate with graphql-tools across the project, updating Cargo.toml and Cargo.lock files to reflect this change. The graphql-tools dependency is now sourced from a specific git branch.
  • Code Refactoring: Updated all use statements in Rust source files (usage.rs, agent.rs, graphql.rs) to import GraphQL parsing functionalities from graphql_tools::parser instead of graphql_parser.
  • API Adaptation: Adjusted the minify_query function call in packages/libraries/sdk-rs/src/graphql.rs to pass a string slice (.as_str()) as required by the new graphql-tools API.
  • Dependency Cleanup: Removed graphql-parser as a direct dependency from graphql-tools, hive-apollo-router-plugin, and hive-console-sdk packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/cli 0.57.2-alpha-20260115082533-8f684a1572e75ff0d06e8c840d943f001a781368 npm ↗︎ unpkg ↗︎
hive 9.0.0-alpha-20260115082533-8f684a1572e75ff0d06e8c840d943f001a781368 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase to use a forked version of graphql-tools instead of graphql-parser. My main feedback concerns the use of a git dependency pointing to a branch, which can impact build reproducibility; I recommend pinning it to a specific commit hash. Additionally, there's a minor performance improvement opportunity by removing an unnecessary clone.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7476.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-7476.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 8f684a1572e75ff0d06e8c840d943f001a781368

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: apollo-router-hive-build

Platforms: linux/amd64

Image Tag: de46a9d4f399b5298da433b94724a218c6789e31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant