-
Notifications
You must be signed in to change notification settings - Fork 124
Upcoming Release Changes #7481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upcoming Release Changes #7481
Conversation
Summary of ChangesHello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by the Changesets release action, prepares for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/cli |
0.57.2-rc-20260115152628-e44fa97c1cff3fe1efed52b955bd5a794c91c0fb |
npm ↗︎ unpkg ↗︎ |
hive |
9.0.0-rc-20260115152628-e44fa97c1cff3fe1efed52b955bd5a794c91c0fb |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7481.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR prepares for the v9.0.0 major release, which introduces a new workflows service to replace the emails and webhooks services. My review focuses on the clarity of the release notes for self-hosted users. I've identified a potential point of confusion in CHANGELOG.md regarding the removal of the old services and have suggested an improvement to make the migration steps clearer.
| Thanks [@n1ru4l](https://github.com/n1ru4l)! - Add a new `workflows` service. This service | ||
| consolidates and replaces the `emails` and `webhooks` services, using a Postgres-backed persistent | ||
| queue for improved stability and reliability. | ||
|
|
||
| If you are running a self-hosted setup the following docker compose changes are required: | ||
|
|
||
| ```diff | ||
| services: | ||
|
|
||
| + workflows: | ||
| + image: '${DOCKER_REGISTRY}workflows${DOCKER_TAG}' | ||
| + networks: | ||
| + - 'stack' | ||
| + depends_on: | ||
| + db: | ||
| + condition: service_healthy | ||
| + environment: | ||
| + NODE_ENV: production | ||
| + PORT: 3014 | ||
| + POSTGRES_HOST: db | ||
| + POSTGRES_PORT: 5432 | ||
| + POSTGRES_DB: '${POSTGRES_DB}' | ||
| + POSTGRES_USER: '${POSTGRES_USER}' | ||
| + POSTGRES_PASSWORD: '${POSTGRES_PASSWORD}' | ||
| + EMAIL_FROM: [email protected] | ||
| + EMAIL_PROVIDER: sendmail | ||
| + LOG_LEVEL: '${LOG_LEVEL:-debug}' | ||
| + SENTRY: '${SENTRY:-0}' | ||
| + SENTRY_DSN: '${SENTRY_DSN:-}' | ||
| + PROMETHEUS_METRICS: '${PROMETHEUS_METRICS:-}' | ||
| + LOG_JSON: '1' | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog states that the workflows service replaces the emails and webhooks services. However, the provided diff for docker-compose.yml only shows the addition of the workflows service. This can be misleading for self-hosted users, who might not remove the old emails and webhooks services, leading to them running unnecessary services.
To ensure a smooth migration, please update the changelog to explicitly state that emails and webhooks services should be removed. It would be best to update the diff block to reflect these removals as well. For example:
services:
- webhooks:
- # ...
-
- emails:
- # ...
+ workflows:
+ # ...Additionally, the depends_on section for the server service may need to be updated to remove dependencies on emails and webhooks.
References
- Changesets for the
hivescope should contain enough information for a self-hosted user to understand the change and its implications, without excessive technical detail. The current changelog entry is missing crucial information about removing old services, which is necessary for a smooth upgrade. (link)
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7481.hive-landing-page.pages.dev |
da1e224 to
2da36be
Compare
2da36be to
38ee667
Compare
38ee667 to
c681f8e
Compare
c681f8e to
d500742
Compare
d500742 to
30ca108
Compare
30ca108 to
c700ca5
Compare
c700ca5 to
5a01900
Compare
5a01900 to
cf8339b
Compare
cf8339b to
72dc7b6
Compare
72dc7b6 to
ffc04d9
Compare
ffc04d9 to
6c28877
Compare
6c28877 to
e44fa97
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@graphql-hive/[email protected]
Patch Changes
e3006e2Thanks @kamilkisiela! - Fixes a bug in Federation composition
and validation where an error was incorrectly reported for interfaces implementing another
interface with a
@key. The validation now correctly applies only to object types implementingthe interface.
[email protected]
Major Changes
#7383
ec77725Thanks @n1ru4l! - Add a new
workflowsservice. This serviceconsolidates and replaces the
emailsandwebhooksservices, using a Postgres-backed persistentqueue for improved stability and reliability.
If you are running a self-hosted setup the following docker compose changes are required:
For different setups, we recommend using this as a reference.
Note: The workflows service will attempt to run postgres migrations for seeding the required
database tables within the
graphile_workernamespace. Please make sure the database user hassufficient permissions. For more information please refer to the
Graphile Worker documentation.
Minor Changes
#7377
8549f22Thanks @adambenhassen! - Add
activeAppDeploymentsGraphQLquery to find app deployments based on usage criteria.
New filter options:
lastUsedBefore: Find stale deployments that were used but not recently (OR withneverUsedAndCreatedBefore)
neverUsedAndCreatedBefore: Find old deployments that have never been used (OR withlastUsedBefore)
name: Filter by app deployment name (case-insensitive partial match, AND with date filters)Also adds
createdAtfield to theAppDeploymenttype.See
Finding Stale App Deployments
for more details.
Patch Changes
#7475
e022bb4Thanks @jdolle! - Fix org owner not being able to select a new
billing plan after downgrading.
#7478
8e2e40dThanks @n1ru4l! - Improve error message when schema composition
exceeds the memory consumption limits.
#7485
e3006e2Thanks @kamilkisiela! - Fixes a bug in Federation composition
and validation where an error was incorrectly reported for interfaces implementing another
interface with a
@key. The validation now correctly applies only to object types implementingthe interface.