-
Notifications
You must be signed in to change notification settings - Fork 124
Upgrade web/app to tailwind v4 #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jonathanawesome, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant infrastructure upgrade, moving the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/cli |
0.57.2-alpha-20260115211303-1221eb373feba43e9dcc87d562a492695b6535cb |
npm ↗︎ unpkg ↗︎ |
hive |
9.0.0-alpha-20260115211303-1221eb373feba43e9dcc87d562a492695b6535cb |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7490.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully upgrades Tailwind CSS from v3 to v4 for the web/app package, which is a significant and well-executed effort. The changes correctly adopt the new CSS-based configuration, updated utility syntax, and necessary dependency adjustments. I've identified a few minor issues where some styles from the old tailwindcss-radix plugin were not fully migrated, and a potential typo in data attribute selectors. Addressing these will ensure all styles are applied correctly post-upgrade. Overall, this is a solid improvement.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7490.hive-landing-page.pages.dev |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…raphql-hive/console into upgrade-web/app-to-tailwind-v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
If I didn't ever migrate to Tailwind 4 and didn't chat with you, I'd assume this was easy :D You managed to wipe up all the blood stains perfectly.
Co-authored-by: Piotr Monwid-Olechnowicz <[email protected]>
Co-authored-by: Piotr Monwid-Olechnowicz <[email protected]>
Background
In preparation for adding new color palettes, this PR upgrades the web/app Tailwind version from 3 to 4.
Description
This PR upgrades the Tailwind version used in web/app from v3 to v4.
Notes
package.jsonand.npmrcto ensure compatibility. Once we move web/docs out of this repo, we can remove these considerations.eslint-plugin-better-tailwindcsswhich supports both v3 and v4. There is some crossover with the Tailwind VSCode extension that I've tried to mitigate, but it's likely that we'll need to do some additional tweaking to the eslint config.