Skip to content

Conversation

@adambenhassen
Copy link
Collaborator

Background

Failing flaky unit tests

Description

Replace fixed wait times with polling using waitUntil() with a timeout to reduce race conditions in timing-sensitive tests

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability of unit tests by migrating from static time-based waits to dynamic condition-based polling. The primary goal is to eliminate flakiness caused by race conditions in timing-sensitive tests, ensuring that tests wait for the actual state change rather than an arbitrary duration. This change improves the stability and robustness of the test suite.

Highlights

  • New waitUntil Utility: Introduced a new asynchronous waitUntil utility function in test-utils.ts that repeatedly checks a condition until it evaluates to true or a specified timeout is reached. This is designed to replace fixed waitFor delays in tests.
  • Flaky Test Fixes: Replaced fixed waitFor calls with the new waitUntil utility in usage.spec.ts to address timing-sensitive race conditions, specifically in tests related to immediate sending and report delivery.
  • Improved Log Assertions: Updated log assertions in usage.spec.ts from toMatchInlineSnapshot to individual toMatch calls for specific log messages, making tests more resilient to minor changes in log output formatting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The new waitUntil utility is a good solution for the flaky tests caused by race conditions. I have one suggestion to improve its versatility for future use.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/cli 0.57.2-alpha-20260115152524-f1a098f828fb68565dec1283bc49ebb68bb7ed81 npm ↗︎ unpkg ↗︎
hive 9.0.0-alpha-20260115152524-f1a098f828fb68565dec1283bc49ebb68bb7ed81 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7501.hive-storybook.pages.dev

@adambenhassen adambenhassen force-pushed the adam/attempt-to-fix-flaky-unit-tests branch from 2ba528e to f1a098f Compare January 15, 2026 15:23
Copy link
Member

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's wait for @n1ru4l to also confirm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: f1a098f828fb68565dec1283bc49ebb68bb7ed81

@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-7501.hive-landing-page.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants