-
Notifications
You must be signed in to change notification settings - Fork 575
feat(apollo-usage-report): report referenced feild by types #4020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-4020.graphql-yoga.pages.dev |
✅ Benchmark Results
|
418b0f5
to
ee4b71e
Compare
ee4b71e
to
48495ac
Compare
// Copied from https://github.com/apollographql/apollo-server/blob/8c6579e5b61276b62dc7e30e6fac9a4242e24daa/packages/server/src/plugin/usageReporting/stats.ts | ||
/* eslint-disable */ | ||
|
||
import type { NonFtv1ErrorPath } from '@apollo/server-gateway-interface'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can avoid this package entirely by copying this too, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can. We discussed it on slack, and we decided that if the Licence allows it, and the dependency is small, it is ok to have it as a dependence.
That's why I've made a copy of the relevant part of the apollo-server code. I don't think it is worth to embed the whole apollo-server
deps just for a class ^^'
hostname?: string; | ||
/** | ||
* The OS identification string. | ||
* The format is `${os.platform()}, ${os.type()}, ${os.release()}, ${os.arch()})` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigator.platform
etc can be used in platform independent way, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't know node had navigator
API.
The thing I don't know is if Apollo is parsing this field or not. If it's paring the string, then we can't use navigator.platform
.
Related to YOGA-19
Related to #3580