feat(integrations): add ruint#1355
Merged
tyranron merged 12 commits intographql-rust:masterfrom Oct 17, 2025
Merged
Conversation
siosw
force-pushed
the
siosw/ruint-integration
branch
from
c79730b to
70efe2d
Compare
Contributor
Author
|
maybe i'm wrong but the CI failure looks unrelated to the PR |
tyranron
added
k::integration
tyranron
approved these changes
Oct 17, 2025
Member
tyranron
left a comment
tyranron
left a comment
There was a problem hiding this comment.
@siosw thank you for your effort!
Don't bother with that test, it's known to be flaky, and there is no way to make it deterministic, unfortunately, since we depend there on nondeterministic compiler output.
Also, I've made few adjustments:
- Exposed the module fed to
#[graphql_scalar]macro aspub, so anyone who desires custom-sized type could just use the module directly (example for doing so is included). - Added implementations for
U8,U16andU32types.
Contributor
Author
|
@tyranron thanks for finishing this up and your work on juniper in general! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1350
Ruint uses const generics to set the size of the uint, I chose to include type aliases for
U64,U128, andU256which are commonly used but i think arguments can be made to include more or less.It would be nice to avoid repeating the doc string for these but i'm unsure if that's possible.
Also wasn't sure where to add this in the change log so left it for now.