feat: update to new Vue grammar scope name#4174
Open
KammererTob wants to merge 2 commits intographql:mainfrom
Open
feat: update to new Vue grammar scope name#4174KammererTob wants to merge 2 commits intographql:mainfrom
KammererTob wants to merge 2 commits intographql:mainfrom
Conversation
🦋 Changeset detectedLatest commit: cf01e19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Just noticed that there already is a PR open for this: #4144 Feel free to close mine if you choose to go with that earlier one. Keeping this open just for visibility, since this completely breaks the Syntax Highlighting for Vue files at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the graphql grammar to work with the new Vue grammar scope name.
Starting with version 3.2.0 of the Vue language tools the scope name was changed to "text.html.vue" instead of "source.vue" (See: vuejs/language-tools#5856).
I am not sure if the addition in the
injectionSelectoris necessary, since in my testing i did not notice any difference, so maybe someone more knowledgeable can give me guidance on this.Closes: vuejs/language-tools#5969