Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand @deprecated to Object types #3818

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expand @deprecated to Object types #3818

wants to merge 1 commit into from

Conversation

fotoetienne
Copy link

See RFC

@netlify
Copy link

netlify bot commented Jan 6, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 442e57b
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63b7d3141fb4c60009ad6e99
😎 Deploy Preview https://deploy-preview-3818--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fotoetienne fotoetienne mentioned this pull request Jan 6, 2023
Draft
@yaacovCR yaacovCR added the spec RFC Implementation of a proposed change to the GraphQL specification label Jan 12, 2023
@fotoetienne fotoetienne requested a review from IvanGoncharov June 1, 2023 16:43
@IvanGoncharov IvanGoncharov requested a review from a team June 1, 2023 18:43
IvanGoncharov
IvanGoncharov requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this rule: https://github.com/graphql/graphql-js/blob/main/src/validation/rules/custom/NoDeprecatedCustomRule.ts
and also add validation preventing the usage of the deprecated type directly here: https://github.com/graphql/graphql-js/blob/main/src/type/validate.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov requested changes

Assignees
No one assigned
Labels
spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fotoetienne @IvanGoncharov @yaacovCR