fix sidebar instability #4329
Closed
fix sidebar instability #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when navigating to https://www.graphql-js.org/api-v16/graphql/ using the top menu bar, the sidebar content expands with the individual mdx files from the api-v16 folder, as if the api/v16 option had been in the sidebar in the first place. This PR adds the API/v16 to the sidebar (in addition to the placement within the menu bar) to avoid this instability.
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
| type: 'separator', | ||
| title: 'FAQ', | ||
| }, | ||
| 'going-to-production': '', | ||
| 'api-v16': { | ||
| 'api-menu': { |
There was a problem hiding this comment.
The goal was to not so this, need to reach out to Dima on how to reset this context.
There was a problem hiding this comment.
Is the final goal to have the subheadings within the API show up somewhere?
There was a problem hiding this comment.
Only when you surf to the api docs else that would not scale to i.e. also having v17
|
Fixed in #4331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when navigating to https://www.graphql-js.org/api-v16/graphql/ using the top menu bar, the sidebar content expands with the individual mdx files from the api-v16 folder, as if the api/v16 option had been in the sidebar in the first place.
This PR adds the API/v16 to the sidebar (in addition to the placement within the menu bar) to avoid this instability.