-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: type generation for graphql servers #4376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.x.x
Are you sure you want to change the base?
Conversation
Hi @sarahxsanders, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sarahxsanders !
I'm from the GraphQL Codegen team at The Guild. I've left some minor comments about our recommendation when using Codegen. Keen to hear your thoughts!
I've fixed CI after rebasing this branch it will work again, apologies for the issues |
Hi @sarahxsanders , thanks for making the changes to recommend presets. |
@eddeee888 you are absolutely welcome to write those sections! happy to collab if you want a review or anything |
Thank you @sarahxsanders ! I'll draft something up this week, and let you know |
Hi @sarahxsanders, I've left a draft here: https://github.com/graphql/graphql-js/pull/4376/files#r2091097002 |
Hello @eddeee888! Thanks so much for your draft, I have added that (only changed a few small nits for formatting/style guide stuff) in my latest commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sarahxsanders ! Feels like we are almost there!
I have some thoughts/feedback, keen to hear your opinions:
- We have not shown how to install Codegen packages in this doc. Do you think we should? I'm thinking it would be useful to readers who are new to GraphQL codegen.
- I have left recommendations to add markdown meta to show filenames to help readers visualise the file they are looking at
I'll share this with the codegen team to see if they have any more feedback!
Co-authored-by: Eddy Nguyen <[email protected]>
Co-authored-by: Eddy Nguyen <[email protected]>
Co-authored-by: Eddy Nguyen <[email protected]>
Co-authored-by: Eddy Nguyen <[email protected]>
@eddeee888 Approved those suggestions, thank you! :) I agree it could be helpful to show how to install the Codegen packages. Were you thinking just the core |
Adds new guide: Type Generation for GraphQL Servers
This is a part of the effort to expand GraphQL.js documentation