Minor validation tweaks from review #4407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
commented
May 22, 2025
| @@ -910,7 +910,7 @@ function createInputObjectDefaultValueCircularRefsValidator( | |||
|
|
|||
| // Check to see if there is cycle. | |||
| const cycleIndex = fieldPathIndex[fieldStr]; | |||
| if (cycleIndex !== undefined && cycleIndex > 0) { | |||
| if (cycleIndex !== undefined) { | |||
There was a problem hiding this comment.
cycleIndex will never be <= 0 since it is only populated via fieldPath.push() which can never return a number less than 1. I considered adding an invariant inside the if, but it didn't seem worthwhile.
JoviDeCroock
approved these changes
May 22, 2025
|
@yaacovCR / @JoviDeCroock If one of you wanted to add a ✔️ on graphql/graphql-spec#793 to confirm it aligns, that would be appreciated! Pretty sure it does though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst reviewing that #3814 aligned with graphql/graphql-spec#793, I spotted these two minor improvements.