fix: check the actual GraphQLDirective instance in isSpecifiedDirective#4511
fix: check the actual GraphQLDirective instance in isSpecifiedDirective#4511ardatan wants to merge 1 commit intographql:16.x.xfrom
GraphQLDirective instance in isSpecifiedDirective#4511Conversation
|
@ardatan is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
a27c4b2 to
ebc31f3
Compare
|
The spec assumes that all directives with the names of specified directives are the actual specified directives, but it seems to me we should be more permissive as possible within the implementation, especially to enable custom/experimental forms of the different directives. In terms of future-proofing this, is the contention that we only need one function describing the actual specified directives, or might we need two different functions, one version that retains the current behavior (returning And basically we have the parallel question with |
Related ardatan/graphql-tools#7716
Fixes the bug when a
GraphQLDirectiveinstance is passed with the same name as specified directives,isSpecifiedDirectivereturns true unexpectedly.