Skip to content

Replace ExecuteSelectionSet with ExecuteGroupedFieldSet #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Replace ExecuteSelectionSet with ExecuteGroupedFieldSet #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b76671b
Extract common logic from ExecuteQuery, ExecuteMutation and ExecuteSu…
benjie Apr 28, 2023
c9837a4
Change ExecuteSelectionSet to ExecuteGroupedFieldSet
benjie Apr 28, 2023
a52310e
Correct reference to MergeSelectionSets
benjie Aug 21, 2023
60a9c35
move Field Collection section earlier (#1111)
yaacovCR Oct 17, 2024
a1de2dd
Merge branch 'main' into benjie/incremental-common
benjie Jan 9, 2025
e8f80c8
Merge branch 'main' into benjie/incremental-common
benjie Mar 6, 2025
213fd2a
Define 'grouped field set'
benjie Mar 6, 2025
383cf8e
that -> which
benjie Mar 6, 2025
48a789b
More similar to prior wording
benjie Mar 6, 2025
0b9eed7
Remove reason from definition
benjie Mar 6, 2025
0728c4a
subGroupedFieldSet -> fieldGroupedFieldSet
benjie Mar 6, 2025
140c3da
Add note for clarity
benjie Mar 6, 2025
65df539
Merge branch 'main' into benjie/incremental-common
benjie Apr 17, 2025
d68df95
move field collections into one section, section reworking, minor wor…
leebyron Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/Section 5 -- Validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ should be unambiguous. Therefore any two field selections which might both be
encountered for the same object are only valid if they are equivalent.

During execution, the simultaneous execution of fields with the same response
name is accomplished by {MergeSelectionSets()} and {CollectFields()}.
name is accomplished by {CollectSubfields()}.

For simple hand-written GraphQL, this rule is obviously a clear developer error,
however nested fragments can make this difficult to detect manually.
Expand Down
Loading