-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update wording for 6.4.1 Coercing Field Arguments #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update wording for 6.4.1 Coercing Field Arguments #1207
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
martinbonnin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
benjie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don’t read the same to me; the existing text reads as “there may be an entry at each argument position, and if there is then its a Value or Variable” whereas the replacement seems to say “each argument position is a Value or Variable” and doesn’t as clearly allow for omission.
I think the existing text is fine as is, though it does feel slightly awkwardly phrased.
|
Both read the same to me, with the new formulation being a bit easier to parse. If we want to be explicit about omission, let's add language? Note that "operation" is also slightly misleading because fragments may also contain arguments. So maybe this? |
|
upon rereading with fresh eyes it does make sense, but yes it's a little awkward. I like @martinbonnin's suggestions! |
This sentence
doesn't quite scan as isis a little awkward to parse