Skip to content

Conversation

@magicmark
Copy link
Contributor

@magicmark magicmark commented Jan 6, 2026

This sentence doesn't quite scan as is is a little awkward to parse

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 2ad4128
🔍 Latest deploy log https://app.netlify.com/projects/graphql-spec-draft/deploys/695c9eb6de96a7000826d547
😎 Deploy Preview https://deploy-preview-1207--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinbonnin martinbonnin added the ✏️ Editorial PR is non-normative or does not influence implementation label Jan 6, 2026
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don’t read the same to me; the existing text reads as “there may be an entry at each argument position, and if there is then its a Value or Variable” whereas the replacement seems to say “each argument position is a Value or Variable” and doesn’t as clearly allow for omission.

I think the existing text is fine as is, though it does feel slightly awkwardly phrased.

@martinbonnin
Copy link
Contributor

martinbonnin commented Jan 6, 2026

Both read the same to me, with the new formulation being a bit easier to parse. If we want to be explicit about omission, let's add language?

Each argument position in an operation may be a literal {Value}, or a {Variable}
to be provided at runtime. Arguments may also be missing if their definition allows it.

Note that "operation" is also slightly misleading because fragments may also contain arguments. So maybe this?

Each argument position in an executable document may be a literal {Value}, or a {Variable}
to be provided at runtime. Arguments may also be missing if their definition allows it.

@magicmark
Copy link
Contributor Author

upon rereading with fresh eyes it does make sense, but yes it's a little awkward. I like @martinbonnin's suggestions!

@magicmark magicmark changed the title Fix typo in 6.4.1 Coercing Field Arguments Update wording for 6.4.1 Coercing Field Arguments Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✏️ Editorial PR is non-normative or does not influence implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants