Skip to content

fix: escape HTML special characters in build.sh to prevent HTML injection #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranitaurlam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: escape HTML special characters in build.sh to prevent HTML injection #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
#!/bin/bash -e
# This script publishes the GraphQL specification document to the web.

# Escape HTML special characters to prevent HTML injection
html_escape() {
local str="$1"
str="${str//&/&}"
str="${str//</&lt;}"
str="${str//>/&gt;}"
str="${str//\"/&quot;}"
echo "$str"
}

# Determine if this is a tagged release
GITTAG=$(git tag --points-at HEAD)

Expand Down Expand Up @@ -58,11 +68,12 @@ HTML="<html>

# Include latest draft
GITDATE=$(git show -s --format=%cd --date=format:"%a, %b %-d, %Y" HEAD)
GITDATE_ESC=$(html_escape "$GITDATE")
HTML="$HTML
<tr>
<td><em>Prerelease</em></td>
<td><a href=\"./draft\" keep-hash>Working Draft</a></td>
<td>$GITDATE</td>
<td>$GITDATE_ESC</td>
<td></td>
</tr>"

Expand All @@ -73,6 +84,10 @@ for GITTAG in $(git tag -l --sort='-*committerdate') ; do
TAGGEDCOMMIT=$(git rev-list -1 "$GITTAG")
GITDATE=$(git show -s --format=%cd --date=format:"%a, %b %-d, %Y" $TAGGEDCOMMIT)

GITTAG_ESC=$(html_escape "$GITTAG")
TAGTITLE_ESC=$(html_escape "$TAGTITLE")
GITDATE_ESC=$(html_escape "$GITDATE")

HTML="$HTML
<tr>"

Expand All @@ -82,9 +97,9 @@ for GITTAG in $(git tag -l --sort='-*committerdate') ; do
HAS_LATEST_RELEASE=1

HTML="$HTML
<td><a href=\"./$GITTAG\" keep-hash>$TAGTITLE</a></td>
<td>$GITDATE</td>
<td><a href=\"$GITHUB_RELEASES/$GITTAG\">Release Notes</a></td>
<td><a href=\"./$GITTAG_ESC\" keep-hash>$TAGTITLE_ESC</a></td>
<td>$GITDATE_ESC</td>
<td><a href=\"$GITHUB_RELEASES/$GITTAG_ESC\">Release Notes</a></td>
</tr>"
done

Expand All @@ -102,4 +117,4 @@ HTML="$HTML
</body>
</html>"

echo $HTML > "public/index.html"
echo "$HTML" > "public/index.html"